aribb25: init at 0.2.7 #96553
aribb25: init at 0.2.7 #96553
Conversation
|
/marvin opt-in |
|
Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here. |
pkgs/top-level/all-packages.nix
Outdated
| @@ -4583,7 +4583,7 @@ in | |||
|
|
|||
| isync = callPackage ../tools/networking/isync { }; | |||
|
|
|||
| itm-tools = callPackage ../development/tools/misc/itm-tools { }; | |||
There was a problem hiding this comment.
There's a bunch of extraneous whitespace cleaning in this file.
There was a problem hiding this comment.
Seems to be the project's .editorconfig doing its thing.
Line 11 in cbf2b88
I think it might be better to separate the commit and keep it as-is because other contributors who also have editorconfig enabled are also going to run into this anyways.
There was a problem hiding this comment.
I did a rebase to fix merge conflicts, and it seems the whitespace issues are now gone.
marvin-mk2
bot
added
awaiting_changes
awaiting_reviewer
and removed
needs_reviewer
awaiting_changes
labels
midchildan
force-pushed
the
add-aribb25
branch
from
6283ce8
to
fec8ae5
Compare
|
/status needs_merger |
| buildInputs = if stdenv.isDarwin then [ PCSC ] else [ pcsclite ]; | ||
|
|
||
| patches = let | ||
| url = pr: "https://code.videolan.org/videolan/${pname}/-/merge_requests/${pr}.patch"; |
There was a problem hiding this comment.
This type of patch is unstable, it might change when the MR changes. That would then break the fixed-output-derivation. You should refer to the relevant commits directly instead.
|
I also fixed the build for macOS. |
| patches = let | ||
| url = commit: "https://code.videolan.org/videolan/${pname}/-/commit/${commit}.diff"; | ||
| in [ | ||
| (fetchpatch { |
There was a problem hiding this comment.
One minor nit: Its always nice to give a few words of explanation and/or an upstream PR link in a comment. This information probably got lost on accident when you switched from PR-patch to commits. Its not worth another review iteration, just for the future :)
Motivation for this change
Add aribb25, a sample implementation of the ARIB STD-B25 standard.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)