Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: d37baf79daf7
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: c376f3ec1196
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Aug 28, 2020

  1. nixos/test-driver: Use guest time when using sleep

    With the Perl driver, machine.sleep(N) was doing a sleep on the guest
    machine instead of the host machine. The new Python test driver however
    uses time.sleep(), which instead sleeps on the host.
    
    While this shouldn't make a difference most of the time, it *does*
    however make a huge difference if the test machine is loaded and you're
    sleeping for a minimum duration of eg. an animation.
    
    I stumbled on this while porting most of all my tests to the new Python
    test driver and particularily my video game tests failed on a fairly
    loaded machine, whereas they don't with the Perl test driver.
    
    Switching the sleep() method to sleep on the guest instead of the host
    fixes this.
    
    Signed-off-by: aszlig <aszlig@nix.build>
    aszlig committed Aug 28, 2020
    Copy the full SHA
    b0ac24a View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2020

  1. Merge pull request #96571 from aszlig/nixos-tests-sleep-guest-time

    nixos/test-driver: Use guest time when using sleep
    flokli committed Aug 29, 2020
    Copy the full SHA
    c376f3e View commit details
    Browse the repository at this point in the history