New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qt5: 5.14.2 -> 5.15.0 #96619
qt5: 5.14.2 -> 5.15.0 #96619
Conversation
I have rebased this to current master and added the change from #95772 to Qt 5.15 as well. |
This should probably go to the staging branch, can you change that? |
I've rebased it to staging. |
I moved the milestone. I want to have this in NixOS 20.09 because the support window for Qt 5.14 will end before NixOS 21.03. I'm building this locally right now, but obviously I won't be able to finish reviewing until tomorrow. 😅 |
This reverts commit bec5405. Qt 5.14 is still supported upstream, so we will not remove it yet.
Qt 5.15 is not officially supported by many packages, notably Plasma.
This reverts commit cf4dc05.
@@ -312,7 +311,6 @@ stdenv.mkDerivation { | |||
[ | |||
"-${lib.optionalString (compareVersion "5.9.0" < 0) "no-"}rpath" | |||
|
|||
"-system-xcb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have these configuration changes been tested with Qt 5.12 and Qt 5.14?
I still want to merge this, but we will not make Qt 5.15 the default version. It is not officially supported by many packages yet, particularly it is unsupported by Plasma. |
@ttuegel So we have to use a version of qt in stable for plasma that won't be supported (at some tiny point before 21.03)? |
From looking at all-packages.nix, default for linux is 5.14 right now, which will be supported until 2020-12-12. |
@worldofpeace We actually need to revert to Qt 5.12 in stable. Plasma 5.18 doesn't support Qt 5.14, and Plasma 5.19 is only supported until October (and isn't merged anyway). |
I don't think we should stick with LTS versions of Plasma if that means we can't upgrade Qt. AFAICT Plasma LTS releases only come around once every 1.5 years, so we would only be able to upgrade Qt every 1.5 years either. If maintaining non-LTS versions (5.19) of Plasma is infeasible, could we instead override the Qt version only for Plasma and keep the system version at 5.15? BTW, did you run into any other build errors with 5.15 aside from Plasma? |
Plasma 5.18 is the only version of Plasma that will have support through our support window for NixOS 20.09, so I don't think we have much choice there. Plasma 5.20 won't be released until October, and Plasma 5.19's support window expires shortly after. We don't have the resources to be backporting security patches onto Plasma 5.19 for six months. Qt 5.12 is also an LTS release, with security updates beyond the support window of NixOS 20.09. The status of different version combinations is:
I can't imagine foisting any combination other than Plasma 5.18 + Qt 5.12 on users of NixOS 20.09. The combination is supported upstream and each has LTS support through our support window. I think anything else would be an utter disaster. Edit:
Maybe. I think we have several custom patches to support Qt 5.14 with various applications, and even though they build, I'm not sure they work right. In general, open source applications are very slow to adapt to new Qt versions, so I don't see any reason we should be so eager. At least, I'd be happier adding the new version and waiting for application maintainers to pin their packages to the new version. |
@ttuegel All of that sounds good to me. I encourage any option that makes Plasma use Qt 5.12. |
I'm going to open two separate pull requests:
I think this meets everyone's needs, and we can get it done quickly. |
Motivation for this change
Update to Qt 5.15.
This is just a rebased version of https://github.com/petabyteboy/nixpkgs/pull/1
All thanks go to @nrdxp and @petabyteboy who did the actual work
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)