Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnirehtet: 2.4 -> 2.5 #96601

Merged
merged 1 commit into from Dec 1, 2020
Merged

gnirehtet: 2.4 -> 2.5 #96601

merged 1 commit into from Dec 1, 2020

Conversation

symphorien
Copy link
Member

the patch is not necessary anymore, as paths to adb and the apk can be
set with environment variables

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@symphorien
gnirehtet: 2.4 -> 2.5
da41eae 
the patch is not necessary anymore, as paths to adb and the apk can be
set with environment variables
@symphorien
Copy link
Member Author

@GrahamcOfBorg build gnirehtet

@symphorien symphorien merged commit 75e36cd into NixOS:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@symphorien