Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fractal: add gtk support to gstreamer #96627

Merged
merged 1 commit into from Sep 6, 2020
Merged

fractal: add gtk support to gstreamer #96627

merged 1 commit into from Sep 6, 2020

Conversation

tnias
Copy link
Contributor

@tnias tnias commented Aug 29, 2020

Closes #96618

Suggested-by: @jtojnar

Motivation for this change

When fractal crashes I can't chat.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

CC maintainers: @dtzWill @worldofpeace

@tnias
fractal: add gtk support to gstreamer
bc454e1 
Closes NixOS#96618

Suggested-by: Jan Tojnar <jtojnar@gmail.com>
@ofborg ofborg bot requested review from dtzWill and worldofpeace August 29, 2020 21:42
symphorien
symphorien approved these changes Aug 30, 2020
View reviewed changes
Copy link
Member

@symphorien symphorien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can reproduce the issue and check that this fixes the issue.

@jtojnar jtojnar merged commit 50285e2 into NixOS:master Sep 6, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Sep 6, 2020

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien approved these changes

@dtzWill dtzWill Awaiting requested review from dtzWill

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fractal crashes when displaying inline video
3 participants
@tnias @jtojnar @symphorien