Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flutter: export mkFlutter #96550

Merged
merged 1 commit into from Aug 29, 2020
Merged

flutter: export mkFlutter #96550

merged 1 commit into from Aug 29, 2020

Conversation

ericdallo
Copy link
Member

@ericdallo ericdallo commented Aug 28, 2020 •
edited

Motivation for this change

Exporting mkFlutter will allow users to build custom versions of flutter via flutterPackages.mkFlutter.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ericdallo
flutter: export mkFlutter
65062ad 
With that, users can build custom versions of flutter
@ericdallo ericdallo self-assigned this Aug 28, 2020
babariviere
babariviere approved these changes Aug 28, 2020
View reviewed changes
Copy link
Member

@babariviere babariviere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danieldk danieldk merged commit e845562 into NixOS:master Aug 29, 2020
@ericdallo ericdallo deleted the export-mkFlutter branch August 29, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@babariviere babariviere babariviere approved these changes

Assignees

@ericdallo ericdallo

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ericdallo @babariviere @danieldk