Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deepin: remove from nixpkgs #96610

Merged
merged 1 commit into from Aug 31, 2020
Merged

deepin: remove from nixpkgs #96610

merged 1 commit into from Aug 31, 2020

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Aug 29, 2020

Motivation for this change

The Deepin Desktop Environment (DDE) is not yet fully packaged in nixpkgs and it has shown a very difficult task to complete, as discussed in #94870. The conclusion is that it is better to completely remove it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Aug 29, 2020

Seems like a perfect project for a flake.

@worldofpeace
Copy link
Contributor

Seems like a perfect project for a flake.

Indeed, it would be a lot easier to not have in nixpkgs because of its complexity. Though IMHO atm I don't think it should be packaged at all.

@Ma27
Copy link
Member

Ma27 commented Aug 29, 2020

I think it would be good to mention this in the release notes and to also add deepin = throw "..."; to aliases.nix.

@FRidh
Copy link
Member

FRidh commented Aug 30, 2020

Merge conflicts.

@romildo
deepin: remove from nixpkgs
b768afb 
The Deepin Desktop Environment (DDE) is not yet fully packaged in
nixpkgs and it has shown a very difficult task to complete, as
discussed in #94870. The
conclusion is that it is better to completely remove it.
@romildo romildo mentioned this pull request Aug 30, 2020
Merged
10 tasks
@FRidh FRidh merged commit 303e0bc into NixOS:master Aug 31, 2020
@FRidh FRidh mentioned this pull request Aug 31, 2020
Merged
23 tasks
@worldofpeace
Copy link
Contributor

I think it would be good to mention this in the release notes and to also add deepin = throw "..."; to aliases.nix.

Yeah. This shouldn't have been merged without using

  • mkRemovedOptionModule
  • a throw
  • a release note with the motivation

@romildo romildo mentioned this pull request Sep 1, 2020
Merged
10 tasks
@romildo
Copy link
Contributor Author

romildo commented Sep 1, 2020

Yeah. This shouldn't have been merged without using

* mkRemovedOptionModule

* a throw

* a release note with the motivation

Done in PR #96879.

@romildo romildo deleted the rm.deepin branch September 2, 2020 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: nixos 8.has: clean-up 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@romildo @FRidh @worldofpeace @Ma27