Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pint: add missing dependencies #96628

Merged
merged 1 commit into from Aug 30, 2020
Merged

pythonPackages.pint: add missing dependencies #96628

merged 1 commit into from Aug 30, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Aug 29, 2020

Motivation for this change

importlib-metadata and packaging appear to have been falsely satisfied by the inclusion of pytestCheckHook in checkInputs. This can be demonstrated by attempting to build this package with doCheck = false and watching it fail.

Also removed the isPy27 clause as package no longer seems to support <3.6 anyway now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from costrouc August 29, 2020 21:55
@risicle
Copy link
Contributor Author

risicle commented Aug 30, 2020

Sure, let me squash that commit in...

@risicle risicle force-pushed the ris-pint-missing-dependencies branch 2 times, most recently from 2a820db to e1575d8 Compare August 30, 2020 10:12
@risicle
pythonPackages.pint: add missing dependencies
3fecd2e 
importlib-metadata and packaging appear to have been falsely satisfied
by the inclusion of pytestCheckHook in checkInputs. this can be
demonstrated by attempting to build this package with doCheck = false.

also removed the isPy27 clause as package no longer seems to support <3.6
anyway now.
@risicle risicle force-pushed the ris-pint-missing-dependencies branch from e1575d8 to 3fecd2e Compare August 30, 2020 10:13
jonringer
jonringer approved these changes Aug 30, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 96628 1

4 packages built:
- datasette (python38Packages.datasette)
- python37Packages.datasette
- python37Packages.pint
- python38Packages.pint

@jonringer jonringer merged commit 5f40ba4 into NixOS:master Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@catern catern catern approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@costrouc costrouc Awaiting requested review from costrouc

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @catern @jonringer