Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustscan: init at 1.8.0 #96576

Merged
merged 2 commits into from Aug 29, 2020
Merged

rustscan: init at 1.8.0 #96576

merged 2 commits into from Aug 29, 2020

Conversation

SuperSandro2000
Copy link
Member

Motivation for this change

Get rustscan into nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk
danieldk suggested changes Aug 29, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you for your first contribution 👍 .

I have added some requested changes.

maintainers/maintainer-list.nix Show resolved Hide resolved
pkgs/tools/security/rustscan/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/rustscan/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/rustscan/default.nix Outdated Show resolved Hide resolved
pkgs/tools/security/rustscan/default.nix Outdated Show resolved Hide resolved
@SuperSandro2000 SuperSandro2000 mentioned this pull request Aug 29, 2020
Merged
@danieldk
Copy link
Contributor

Thanks for making the changes! I pushed a few more changes:

  • Simplified postPatch a bit.
  • nmap should not be in nativeBuildInputs.
  • Added skips for some tests, because they fail in the nix sandbox.

@SuperSandro2000
Copy link
Member Author

Thanks for the help! I am not running nixOS (yet?) so some of the tests are not that easy for me. I did a quick test and everything still works.

danieldk
danieldk approved these changes Aug 29, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems to work well 👍 .

@danieldk danieldk merged commit d6d64de into NixOS:master Aug 29, 2020
@danieldk
Copy link
Contributor

danieldk commented Aug 29, 2020 •
edited

Thanks for the help! I am not running nixOS (yet?) so some of the tests are not that easy for me.

If you enable Nix sandboxing, it should not make a big difference. Unless you are on macOS, where things are a bit trickier.

@SuperSandro2000 SuperSandro2000 deleted the rustscan branch August 29, 2020 17:50
@SuperSandro2000
Copy link
Member Author

If you enable Nix sandboxing, it should not make a big difference. Unless you are on macOS, where things are a bit trickier.

I installed nix on Debian with the help of the package nix-setup-systemd. It has sandboxing disabled but as far as I can tell it is only because it fails on aarch64. I am on x84_amd64 so I will probably make my next contributions with sandboxing enabled. Thanks for the heads up.

@SuperSandro2000 SuperSandro2000 mentioned this pull request Aug 29, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SuperSandro2000 @danieldk