Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dnspython: reintroduce version 1.16.0, fix electrum build #96596

Closed
wants to merge 2 commits into from
Closed

dnspython: reintroduce version 1.16.0, fix electrum build #96596

wants to merge 2 commits into from

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Aug 29, 2020 •
edited

Motivation for this change

Fix #96477

Reintroduced dnspython 1.x, added to dependency of electrum

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak mentioned this pull request Aug 29, 2020
Closed
@FRidh
Copy link
Member

FRidh commented Aug 29, 2020

The expression can be added directly in the electrum expression, no need to have it in the package set.

@prusnak
Copy link
Member Author

prusnak commented Aug 29, 2020

Most probably there are other packages broken by the version bump. I prefer this way so we can fix them quickly and not monkey-patch them one by one.

@ofborg ofborg bot requested review from np, ehmry and joachifm August 29, 2020 11:31
@FRidh FRidh self-assigned this Aug 29, 2020
@jonringer
Copy link
Contributor

we would prefer to keep python-modules as "coherent" as possible, please put the version override in electrum, an example can be found: #96481

@prusnak
Copy link
Member Author

prusnak commented Aug 29, 2020

Superseded by #96625

@prusnak prusnak closed this Aug 29, 2020
@prusnak prusnak deleted the dnspython1 branch August 29, 2020 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees

@FRidh FRidh

Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

electrum: broken on master because of dnspython update
3 participants
@prusnak @FRidh @jonringer