Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

electron-cash: ease protobuf dependency #96597

Closed
wants to merge 1 commit into from
Closed

electron-cash: ease protobuf dependency #96597

wants to merge 1 commit into from

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Aug 29, 2020

Motivation for this change

We have protobuf 3.12 in the master so electron-cash is not building anymore. This change eases the dependency requirement and fixes the build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak
Copy link
Member Author

prusnak commented Aug 29, 2020

There is a new version 4.1.0 which does not suffer from this. Will do a version update PR instead.

@prusnak prusnak closed this Aug 29, 2020
@prusnak prusnak deleted the electron-cash branch August 29, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@prusnak