sonata: fix gsettings schemas #96622
Conversation
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
| @@ -16,7 +16,7 @@ in buildPythonApplication rec { | |||
|
|
|||
| disabled = !isPy3k; | |||
|
|
|||
| nativeBuildInputs = [ pkgconfig gettext ]; | |||
| nativeBuildInputs = [ pkgconfig gettext glib ]; | |||
There was a problem hiding this comment.
this should be a buildInputs and a setup hook wrapGAppsHook should never be in buildInputs, but rather nativeBuildInputs.
There was a problem hiding this comment.
There was a problem hiding this comment.
actually, the dependencies in here are very strange. gobject-introspection is propagated, but that isn't a python dependency. gobject-introspection should be native and gtk3 should be build.
It also uses pythonPath and propagatedBuildInputs, and for a python package I don't see why we couldn't just use pythonPath. Also note that gobject-introspection's setup-hook isn't working correctly here #56943, so you need to set strictDeps = false. Also reference the issue in a comment above that line.
There was a problem hiding this comment.
glib is only used for the hooks here, that's why I put it in nativeBuildInputs. I had no idea what was going on. Thanks for pointing me to #56943, adding strictDeps worked!
Motivation for this change
Otherwise you get the error
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)