Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos.manual: introduce Wayland section #98938

Merged
merged 1 commit into from Nov 9, 2020
Merged

nixos.manual: introduce Wayland section #98938

merged 1 commit into from Nov 9, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Sep 27, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof
Copy link
Member Author

raboof commented Oct 22, 2020

/marvin opt-in
/status needs_reviewer

@marvin-mk2 marvin-mk2 bot added the marvin label Oct 22, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Oct 22, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

berbiche
berbiche reviewed Oct 30, 2020
View reviewed changes
Copy link
Member

@berbiche berbiche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for a topic on Wayland

nixos/doc/manual/configuration/wayland.xml Outdated Show resolved Hide resolved
nixos/doc/manual/configuration/wayland.xml Outdated Show resolved Hide resolved
nixos/doc/manual/configuration/wayland.xml Outdated Show resolved Hide resolved
@raboof @berbiche
nixos.manual: introduce Wayland section
c9b669a 
Co-Authored-By: Nicolas Berbiche <nicolas@normie.dev>
@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 4, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

1 similar comment
@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 7, 2020

Reminder: Please review!

This Pull Request is awaiting review. If you are the assigned reviewer, please have a look. Try to find another reviewer if necessary. If you can't, please say so. If the status is not accurate, please change it. If nothing happens, this PR will be put back in the needs_reviewer queue in one day.

@raboof raboof mentioned this pull request Nov 9, 2020
Open
timokau
timokau approved these changes Nov 9, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good start for wayland docs. Thanks!

@timokau timokau merged commit b839d4a into NixOS:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berbiche berbiche berbiche left review comments

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@raboof @timokau @berbiche