Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python3Packages.curio: fix tests on darwin #98927

Merged
merged 1 commit into from Sep 27, 2020
Merged

[20.09] python3Packages.curio: fix tests on darwin #98927

merged 1 commit into from Sep 27, 2020

Conversation

tricktron
Copy link
Member

Motivation for this change

Backport of: 22cd2a2

ZHF: #97479

cc @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

python3Packages.curio: fix tests on darwin
fb4b2e5 
Refactors to pytestCheckHook.

(cherry picked from commit 22cd2a2)
@tricktron tricktron mentioned this pull request Sep 27, 2020
Closed
@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: python labels Sep 27, 2020
@ofborg ofborg bot requested a review from marsam September 27, 2020 09:58
@marsam marsam merged commit ba756b6 into NixOS:release-20.09 Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

@marsam marsam Awaiting requested review from marsam

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tricktron @marsam