Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.pybase64: Upgrade to python 3 #98939

Merged
merged 1 commit into from Sep 27, 2020
Merged

Conversation

thall
Copy link
Contributor

@thall thall commented Sep 27, 2020

Motivation for this change

Python 2 ist supported.

ZHF: #97479
https://hydra.nixos.org/build/127647482

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle
Copy link
Contributor

risicle commented Sep 27, 2020

Py2 support dropped mayeut/pybase64@6c246d1

LGTM, tested macos 10.14.

@risicle risicle merged commit 6156363 into NixOS:master Sep 27, 2020
@risicle risicle added the 9.needs: port to stable A PR needs a backport to the stable release. label Sep 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants