Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging of eints and bottle #17

Merged
merged 5 commits into from Sep 27, 2020

Conversation

TrueBrain
Copy link
Member

And one minor fix found along the way.

In general, print/stderr etc don't end up in tools monitoring software for problems. They do hook into logging infrastructure and can do all kind of funky things because of it.

Logging errors instead of printing them give a timestamp, and the
logging facility can filter on events this way.
Bottle uses "stderr" or "wsgi.errors" to report errors, instead
of logging infrastructure. This means that tools like Sentry do
not see any errors.
Most other server implementations do this already, but not the
WSGIRefServer.
@TrueBrain TrueBrain merged commit bac71d9 into OpenTTD:master Sep 27, 2020
@TrueBrain TrueBrain deleted the code_cleanup_2 branch September 27, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants