Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.fsspec: fix tests on darwin, 0.7.4 -> 0.8.3 #98932

Merged
merged 1 commit into from Sep 27, 2020

Conversation

tricktron
Copy link
Member

Motivation for this change

ZHF: #97479

I disabled one failing tests on darwin.

cc: @NixOS/nixos-release-managers

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 6.topic: python labels Sep 27, 2020
@ofborg ofborg bot requested a review from costrouc September 27, 2020 11:51
@tricktron tricktron changed the title python3Packages.fsspec: fix tests on darwin, 0.7.4 -> 0.8.3 pythonPackages.fsspec: fix tests on darwin, 0.7.4 -> 0.8.3 Sep 27, 2020
@tricktron tricktron changed the title pythonPackages.fsspec: fix tests on darwin, 0.7.4 -> 0.8.3 python3Packages.fsspec: fix tests on darwin, 0.7.4 -> 0.8.3 Sep 27, 2020
@risicle
Copy link
Contributor

risicle commented Sep 27, 2020

@ofborg build python37Packages.s3fs python37Packages.scikitimage python37Packages.aplpy python37Packages.pyfftw python37Packages.dask-mpi python37Packages.caffe

A random smattering of rebuilds

@risicle
Copy link
Contributor

risicle commented Sep 27, 2020

WFM macos 10.14

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the bump seems to cause some dask regressions for me, can someone else try building?

builder for '/nix/store/ih6vk98llklc0dbzvwvkdi46d8fkisr9-python3.7-dask-2.22.0.drv' failed with exit code 1; last 10 log lines:
    #3369
  XFAIL dask/tests/test_order.py::test_avoid_upwards_branching[edcba]
    Can't please 'em all
  XFAIL dask/tests/test_order.py::test_run_smaller_sections[abcde]
    This is challenging to do precisely
  XFAIL dask/tests/test_order.py::test_run_smaller_sections[edcba]
    This is challenging to do precisely
  XFAIL dask/tests/test_order.py::test_avoid_upwards_branching[abcde]
    Can't please 'em all
  = 4 failed, 6628 passed, 779 skipped, 41 xfailed, 1 xpassed, 6 warnings in 227.52s (0:03:47) =
cannot build derivation '/nix/store/n1xfwcak67iynn73665lchm9xiiy4gi1-python3.7-dask-glm-0.2.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/jlxn22zv95v9wr10s763lhraq30mi5xc-python3.7-distributed-2.23.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/jpcp4cxamsdhd0xih4qp7hblha3dpfa8-python3.7-intake-0.6.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/c2zg61x7j71fsyw5amkvhx28h6ps2mri-python3.7-pyFFTW-0.12.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/7nw74ksarinhfbvblz9f756dl01q57rf-python3.7-scikit-image-0.17.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/z54lxsg3wdwaklfhrsxaczy6wib6rrcr-python3.7-sparse-0.10.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/37j0ph9r2m8zq8wjx9bfk8yk71v4l5zx-caffe-1.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/3lrascq2xrcj5lvm4gfa9h0xnv8q5rwc-python3.7-PIMS-0.5.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/qbqq7l9rfsqa1yl2v41sh5c9mz6z705d-python3.7-aplpy-2.0.3.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/31h5jssjijb8im8sxr5in8l256mqf3xf-python3.7-batchgenerators-0.20.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/qi95b4krrrgzr1pbk01wmyikazx5i7d2-python3.7-clifford-1.3.1.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/m6slg7hwp3p0ajikhyhc6dx59vwn2p3c-python3.7-dask-gateway-0.8.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/ymhksmpgcnjh89z7xnl1ph69g8hk98n3-python3.7-dask-jobqueue-0.7.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/5nhk7ynjcmssh2vrs50gx1lhnmw3rjav-python3.7-dask-ml-1.6.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/qbb21g5ycxyk3fpnk4sw8m1avivzpsrr-python3.7-dask-mpi-2.21.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/ga7yx9xmm47rmrx1r4z00n88srz1h1ic-python3.7-dask-xgboost-0.1.11.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/6dy3swmg9iv2fsi3k88xi8v91amkbc68-python3.7-datashader-0.11.1.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/89w4xdfd6v40wcp1dgj5xj4qy0bxi6l1-python3.7-glymur-0.8.18.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/6pnz2z30z8y050qp26anfgk9c04qdyjw-python3.7-image-match-1.1.2.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/5grpsmi2lnc0fa7lk76gqamm90kh86gb-python3.7-imagecorruptions-1.1.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/pxaa1lf2zffj8xwypmylxpn5d4nsapy2-python3.7-rl-coach-1.0.1.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/kyiyvfxgzrsykwwsa63flw7f0vqd6020-python3.7-streamz-0.5.5.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/mp458a8zny84zbr4mgy9fll71py4v8a4-python3.7-stumpy-1.4.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/9s6dzpl3nkahzw4wal8q6wprd2c1v5rl-python3.7-tensorly-0.4.5.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/2843i0rjm23rq70660416in947p8q1z4-python3.7-dask-image-0.3.0.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/q13f6r2ancymvn34yxdymfnym9rnkpch-python3.7-imgaug-0.4.0.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/mkww0klry8hhlv2zyzddzv6l90wa08vs-python3.7-spectral-cube-0.4.5.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/q7wzzcgqpws4a8bnnz6vs6rh90zsfzvv-python3.7-stytra-0.8.34.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/nnlg9gr31ifhav2ifsfhkw01q812r3sl-python3.7-sunpy-1.0.6.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/l06hwyhiins24hi5hdzhzsfs3d7w13kc-python3.7-mask-rcnn-2.1.drv': 2 dependencies couldn't be built

@jonringer
Copy link
Contributor

if ofborg can build dask, then I'm fine with this. The test suite uses pytest-xdist, and might just be failing from high core count.

@GrahamcOfBorg build python37Packages.dask
@GrahamcOfBorg build python3Packages.dask

@jonringer jonringer merged commit 4dbd770 into NixOS:master Sep 27, 2020
@risicle
Copy link
Contributor

risicle commented Sep 27, 2020

The test suite uses pytest-xdist, and might just be failing from high core count.

Humblebrag if ever I saw one.

@tricktron tricktron deleted the fix-fsspec-darwin branch September 27, 2020 19:56
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/is-there-a-feasible-way-to-debug-test-hydra-darwin-failures-quickly/9201/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants