Electron player: init at 2.0.8 #96253
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
hey, can you make 2 commits out of this PR? one for the maintainers attributen (for which the commit message already seems correct) and one for the package addition (which seems to be inside the other commit by accident). cheers |
Sure, done! |
|
hey, can you maybe do it the other way around, since the package addition depends on the maintainer addition |
Ah, didn't thought of that haha, done! |
| name = "${pname}-${version}"; | ||
|
|
||
| src = fetchurl { | ||
| url = "https://github.com/oscartbeaumont/ElectronPlayer/releases/download/v${version}-rc4/${name}.AppImage"; |
There was a problem hiding this comment.
weird, that rc4 is part of the url, although this is a stable release. But seems to be an upstream issue. This will probably change on the next stable release and the rc4 should be removed here then. Maybe you can add a comment explaining that?
There was a problem hiding this comment.
I'm not sure I completely understand, I should add a comment to remind the other maintainers / me to remove the -rc4 for the next releases, or do you want me to downgrade the version to 2.0.7 as the appimage was released with not additionals tags than 2.0.7 ?
There was a problem hiding this comment.
yes, just a reminder to remove the -rc4 if someone just bumps the version should be fine. since 2.0.8 seems to be proper release there is no need to downgrade to 2.0.7
There was a problem hiding this comment.
No problem, is it good ?
|
Should this really be in nixpkgs? The application isn't built from source even though they are available and the website states:
Doesn't this make it non-free or something like that? |
|
We have other packages which are not build from source, even though they could be. Building electron applications always tends to be a tedious process, but can also be done later if someone has the motivation to do it. |
Motivation for this change
Electron player wasn't packaged yet.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)