Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qtbase: Move libtiff dependency from qtbase to qtimageformats #96210

Merged
merged 1 commit into from Aug 27, 2020
Merged

qtbase: Move libtiff dependency from qtbase to qtimageformats #96210

merged 1 commit into from Aug 27, 2020

Conversation

chkno
Copy link
Member

@chkno chkno commented Aug 24, 2020

Motivation for this change

qbase is declared to depend upon libtiff, but doesn't appear to actually depend upon it.

This caused pain in #88591, in which a package requires its own version of libtiff, clashing with qtbase's phantom libtiff.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
    This affects 1406 packages, which is a lot to build for me. Also, qtquickcontrols is blocking channels #96159 is currently blocking many of them.
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@chkno chkno requested a review from ttuegel as a code owner August 24, 2020 21:40
@chkno chkno mentioned this pull request Aug 24, 2020
Merged
10 tasks
@ofborg ofborg bot requested review from periklis, bkchr and qknight August 24, 2020 21:49
@periklis periklis removed their request for review August 25, 2020 07:31
@FRidh FRidh changed the base branch from master to staging August 27, 2020 06:47
@FRidh FRidh merged commit 4bac8a7 into NixOS:staging Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel ttuegel is a code owner

@bkchr bkchr Awaiting requested review from bkchr

@qknight qknight Awaiting requested review from qknight

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 101-500 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chkno @FRidh