Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lutris: add harfbuzz to fhsenv #96245

Merged
merged 1 commit into from Aug 25, 2020
Merged

lutris: add harfbuzz to fhsenv #96245

merged 1 commit into from Aug 25, 2020

Conversation

Moredread
Copy link
Contributor

@Moredread Moredread commented Aug 25, 2020 •
edited

Motivation for this change

libpango needs harfbuff, I can't find the log line that lead me to the problem anymore though.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Moredread
lutris: add harfbuzz to fhsenv
394b8e3 
libpango needs harfbuff
jonringer
jonringer approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pango propagates harfbuzz, so there shouldn't be any increase in closure size. But I'm sure the buildFHSUserEnv will need it to be explicitly mentioned for it to appear in the FHS env.

jonringer
jonringer approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 96245 1

2 packages built:
- lutris
- lutris-free

@jonringer jonringer merged commit 27b77e9 into NixOS:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Moredread @jonringer