Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nano: 5.0 -> 5.2 #96181

Merged
merged 1 commit into from Aug 25, 2020
Merged

nano: 5.0 -> 5.2 #96181

merged 1 commit into from Aug 25, 2020

Conversation

lsix
Copy link
Member

@lsix lsix commented Aug 24, 2020

See https://lists.gnu.org/archive/html/info-gnu/2020-08/msg00008.html
for release announcement.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 96181 1

1 package marked as broken and skipped:
- rssh
2 packages blacklisted:
- tests.nixos-functions.nixos-test
- tests.nixos-functions.nixosTest-test
12 packages built:
- cabal2nix
- crip
- cvs
- cvs2svn
- cvs_fast_export
- cvsps
- cvsq
- dep2nix
- nano
- nix-prefetch-cvs
- nix-prefetch-scripts
- nix-update-source

No regressions compared to the previous version bump.

Nano runs as expected.

@danieldk danieldk merged commit 39b5a15 into NixOS:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants