jellyfin: fix download URL #96221
Closed
jellyfin: fix download URL #96221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The download URL layout appears to have been changed since NixOS#95889, causing the previous URLs to become invalid. This commit fixes the URL template to fit the new layout.
danieldk
reviewed
Aug 25, 2020
There was a problem hiding this comment.
I have nothing against changing the URL, but the old one seems to work again?
$ nix-prefetch-url --unpack https://repo.jellyfin.org/releases/server/portable/stable/combined/jellyfin_10.6.3.tar.gz
unpacking...
[69.7 MiB DL]
path is '/nix/store/zrq7v4mwq6f9flvzj2kp97wy8fqsmavn-jellyfin_10.6.3.tar.gz'
0yyh7x6b707vxdibaj3vwkdl2iaf8dv6kwm8rn277c8nri52hqy7
Gah, you're right - I think I was actually seeing the failure fixed by #95889, due to an older nixpkgs ref, and wrongly jumped to the conclusion that things had changed since that PR. I think we can just delete this then. Sorry for the noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The download URL layout appears to have been changed since #95889,
causing the previous URLs to become invalid. This commit fixes the URL
template to fit the new layout.
Motivation for this change
Download URL has broken (presumably unilaterally upstream) since #95889. This trivial PR fixes it.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)