Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gopass: 1.9.2 -> 1.10.0 #96224

Merged
merged 1 commit into from Aug 27, 2020
Merged

gopass: 1.9.2 -> 1.10.0 #96224

merged 1 commit into from Aug 27, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Aug 25, 2020

Motivation for this change

https://github.com/gopasspw/gopass/releases/tag/v1.10.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from andir and kalbasit August 25, 2020 03:16
@doronbehar
Copy link
Contributor

doronbehar commented Aug 25, 2020 •
edited

Thanks for updating this. Note the breaking changes and the new binaries in $out/bin/. I'd suggest this patch in addition to the current:

diff --git c/pkgs/tools/security/gopass/default.nix i/pkgs/tools/security/gopass/default.nix
index 11337a49be4..5dbb0ce7fc6 100644
--- c/pkgs/tools/security/gopass/default.nix
+++ i/pkgs/tools/security/gopass/default.nix
@@ -42,8 +42,10 @@ buildGoModule rec {
   '';
 
   postFixup = ''
-    wrapProgram $out/bin/gopass \
-      --prefix PATH : "${wrapperPath}"
+    for bin in $out/bin/*; do
+      wrapProgram $bin \
+        --prefix PATH : "${wrapperPath}"
+    done
   '';
 
   meta = with stdenv.lib; {

@doronbehar
Copy link
Contributor

LGTM

@marsam marsam merged commit b3ae6aa into NixOS:master Aug 27, 2020
@marsam marsam deleted the update-gopass branch August 27, 2020 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

@andir andir Awaiting requested review from andir

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @doronbehar