Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GVST: init at 0.0.1-beta #96190

Closed
wants to merge 1 commit into from
Closed

GVST: init at 0.0.1-beta #96190

wants to merge 1 commit into from

Conversation

ezemtsov
Copy link
Contributor

@ezemtsov ezemtsov commented Aug 24, 2020

Collection of free audio plugins

Contains the following plugins:

Effects

  • GBand - Band-pass filter.
  • GChorus - Chorus effect.
  • GClip - Wave-shaping signal clipper.
  • GComp - Compressor.
  • GComp2 - Compressor.
  • GDelay - Delay effect.
  • GDuckDly - Ducking delay effect.
  • GFader - Signal gain (-100 to 0 dB).
  • GGain - Signal gain (-12 to 12 dB).
  • GGate - Gate.
  • GGrain - Granular resynthesis.
  • GHi - High-pass filter.
  • GLow - Low-pass filter.
  • GLFO - Triple LFO effect.
  • GMax - Limiter.
  • GMonoBass - Bass stereo imaging effect.
  • GMulti - Multi-band compressor and stereo enhancer.
  • GNormal - Noise generator for avoiding denormal problems.
  • GRevDly - Reverse delay effect.
  • GSnap - Pitch-correction.
  • GTune - Chromatic tuner.

Instruments

  • GSinth - Mono synth using three continuous portamento sine generators.
  • GSinth2 - Extends GSinth by adding triangle, square and saw-tooth wave.
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Collection of open-source audio plugins

Contains the following plugins:

  Effects
  - GBand - Band-pass filter.
  - GChorus - Chorus effect.
  - GClip - Wave-shaping signal clipper.
  - GComp - Compressor.
  - GComp2 - Compressor.
  - GDelay - Delay effect.
  - GDuckDly - Ducking delay effect.
  - GFader - Signal gain (-100 to 0 dB).
  - GGain - Signal gain (-12 to 12 dB).
  - GGate - Gate.
  - GGrain - Granular resynthesis.
  - GHi - High-pass filter.
  - GLow - Low-pass filter.
  - GLFO - Triple LFO effect.
  - GMax - Limiter.
  - GMonoBass - Bass stereo imaging effect.
  - GMulti - Multi-band compressor and stereo enhancer.
  - GNormal - Noise generator for avoiding denormal problems.
  - GRevDly - Reverse delay effect.
  - GSnap - Pitch-correction.
  - GTune - Chromatic tuner.

  Instruments
  - GSinth - Mono synth using three continuous portamento sine generators.
  - GSinth2 - Extends GSinth by adding triangle, square and saw-tooth wave.
stdenv.mkDerivation rec {
name = "${pname}-${version}";

src = fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try using fetchzip? That should remove the necessity for unzip.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
src = fetchurl {
src = fetchzip {

Comment on lines +1 to +2
{ stdenv
, lib
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ stdenv
, lib
{ stdenv

, libX11
, libXt
, cairo
, unzip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
, unzip

stdenv.mkDerivation rec {
name = "${pname}-${version}";

src = fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
src = fetchurl {
src = fetchzip {

sha256 = "0nv64pyyjz3inxsd0grcp5sjckrx6p84zyl08jjrmzwyha4ic420";
};

nativeBuildInputs = [ unzip autoPatchelfHook ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nativeBuildInputs = [ unzip autoPatchelfHook ];
nativeBuildInputs = [ autoPatchelfHook ];

Comment on lines +30 to +33

unpackPhase = ''
unzip $src
'';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
unpackPhase = ''
unzip $src
'';

meta = with stdenv.lib; {
homepage = https://www.gvst.co.uk;
description = "Collection of open-source audio plugins";

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

- GSinth2 - Extends GSinth by adding triangle, square and saw-tooth wave.
'';
platforms = platforms.linux;
maintainers = [ maintainers.ezemtsov ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
maintainers = [ maintainers.ezemtsov ];
maintainers = with maintainers; [ ezemtsov ];

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 96190 run on x86_64-linux 1

@ezemtsov ezemtsov closed this Nov 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants