multimc: remove unneeded flag #96192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Artturin
changed the title
Artturin
changed the title
|
oops i was thinking of my other pr |
solson
approved these changes
Oct 10, 2020
There was a problem hiding this comment.
I've been going through my home directory seeing what I could make follow the XDG basedir spec, and I was just about to submit this exact same pull request. I can confirm that multimc now does the right thing and uses ~/.local/share/multimc on my machine.
The one downside is that the update will confuse every user who doesn't know they need to move the directory or tell multimc where to look. Is there some way we can ease the transition?
|
Result of 1 package built:
|
|
I almost had a heart attack when I updated and all my instances weren't there. Thank god for github otherwise I would be very sad :( |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
--add-flags "-d \$HOME/.multimc/"was needed when the package was first added in 2015 since the default location was in the nix store.https://github.com/MultiMC/MultiMC5/blob/db926a546e2c58227ab1dcb129b056213d33d6f5/application/MultiMC.cpp#L129
nowadays it uses "$XDG_DATA_HOME" or "/.local/share" by default so the option isn't needed.
https://github.com/MultiMC/MultiMC5/blob/develop/application/MultiMC.cpp#L252
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)