esy: init at 0.6.6 #96234
Closed
esy: init at 0.6.6 #96234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not in favor of using an FHS root for this, but I'm also not using reason anymore so feel free to discard my opinion. |
|
Benefit of the FHS root is the OPAM ecosystem will work without requiring changes to any packages. I do not have an amazing amount of experience with Nix though, so I am unsure what the trade-offs are with this solution. I copied this approach from the flutter compiler. |
Following on from PR NixOS#65098, this commit makes dose3 compile (all that was missing was to compile the native version of cudf), and also esy. Various packages have been updated too, and esy's node dependency esy-solve-cudf has been packaged. A new overlay is added for esyOcamlPackages, as mainline cmdliner and angstrom doesn't successfully compile esy. It's anticipated that more esy-specific deviations might occur. Most of these changes were taken and adapted from esy/esy#994 and NixOS#85835 Co-authored-by: Xavier Zwirtz <me@xavierzwirtz.com>
SuperSandro2000
requested changes
Jan 18, 2021
|
|
||
| meta = { | ||
| description = "CUDF (for Common Upgradeability Description Format) is a format for describing upgrade scenarios in package-based Free and Open Source Software distribution."; | ||
| license = stdenv.lib.licenses.lgpl3; |
There was a problem hiding this comment.
Please add yourself as a maintainer.
| createFindlibDestdir = true; | ||
|
|
||
| meta = { | ||
| description = "CUDF (for Common Upgradeability Description Format) is a format for describing upgrade scenarios in package-based Free and Open Source Software distribution."; |
There was a problem hiding this comment.
Suggested change
| description = "CUDF (for Common Upgradeability Description Format) is a format for describing upgrade scenarios in package-based Free and Open Source Software distribution."; | |
| description = "Format for describing upgrade scenarios in package-based Free and Open Source Software distribution"; |
|
|
||
| meta = { | ||
| description = "CUDF (for Common Upgradeability Description Format) is a format for describing upgrade scenarios in package-based Free and Open Source Software distribution."; | ||
| license = stdenv.lib.licenses.lgpl3; |
There was a problem hiding this comment.
Suggested change
| license = stdenv.lib.licenses.lgpl3; | |
| license = lib.licenses.lgpl3; |
plus or only?
| { stdenv, fetchurl, ocaml, ocamlbuild, findlib | ||
| , cppo, cudf, ocamlgraph, ocaml_extlib, re, perl, ncurses }: | ||
|
|
||
| let base_patch_url = "https://raw.githubusercontent.com/ocaml/opam-repository/master/packages/dose3/dose3.5.0.1/files"; |
There was a problem hiding this comment.
Please replace the version number with the version variable.
|
|
||
| meta = { | ||
| description = "Dose library (part of Mancoosi tools)."; | ||
| license = stdenv.lib.licenses.lgpl3; |
There was a problem hiding this comment.
Please add yourself as a maintainer.
Suggested change
| license = stdenv.lib.licenses.lgpl3; | |
| license = lib.licenses.lgpl3; |
plus or only?
| meta = { | ||
| homepage = https://github.com/andreypopp/esy-solve-cudf; | ||
| description = "package.json workflow for native development with Reason/OCaml"; | ||
| license = stdenv.lib.licenses.gpl3; |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Packaging of the esy package manager, by building on #65098, #85835 and esy/esy#994.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)