Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/octoprint: improve example #96204

Merged
merged 1 commit into from Aug 25, 2020
Merged

nixos/octoprint: improve example #96204

merged 1 commit into from Aug 25, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Aug 24, 2020 •
edited

Motivation for this change

noticed in https://www.reddit.com/r/NixOS/comments/ifmg55/octoprint_plugins/ that the example will actually cause an error. Fixed the example.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer jonringer force-pushed the improve-octoprint-plugin-example branch from c252190 to d4a51ca Compare August 24, 2020 20:38
@jonringer
Copy link
Contributor Author

also changed it to show m33-fio as m3d-fio i guess is deprecated

@jonringer jonringer merged commit 7e07d14 into NixOS:master Aug 25, 2020
@jonringer jonringer deleted the improve-octoprint-plugin-example branch August 25, 2020 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WhittlesJr WhittlesJr WhittlesJr approved these changes

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @WhittlesJr