Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests/os-prober.nix: port to python #96187

Merged
merged 1 commit into from Aug 24, 2020
Merged

nixos/tests/os-prober.nix: port to python #96187

merged 1 commit into from Aug 24, 2020

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Aug 24, 2020

Motivation for this change

#72828

This is a simple rebase of @symphorien's code from this branch onto recent master, which seems to build just fine on my machine.

I also cannot reproduce the problems observed in this comment by @flokli.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
Copy link
Contributor

flokli commented Aug 24, 2020

Indeed, this seems to work. Might have been a transient failure in nixpkgs, I don't know 🤷

Thanks for picking this up!

@flokli flokli merged commit c4ef188 into NixOS:master Aug 24, 2020
@ajs124 ajs124 deleted the os-prober-python branch August 24, 2020 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajs124 @flokli @symphorien