Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ghcjs 8.6 [haskell-updates] #96193

Merged
merged 4 commits into from Aug 26, 2020

Conversation

dhruvio
Copy link
Contributor

@dhruvio dhruvio commented Aug 24, 2020

Closing original PR (#96141) in favour of this one.

Fixes #84563 and #95931

cc @cdepillabout @maralorn @ElvishJerricco

NOTE: I am not sure how to test changes to configuration-hackage2nix.yaml

@maralorn
Copy link
Member

maralorn commented Aug 24, 2020

@dhruvio If you wanna try to test that changes to the yaml file do the following:

  1. Clone nixos/cabal2nix
  2. Symlink your nixpkgs into cabal2nix/nixpkgs
  3. Run caba2nix/regenerate-nixpkgs.sh

See that script for more explanations in the comments.

EDIT: We should really make a written how-to guide about this …

# lost the next time `update-stackage.sh` runs.
default-package-overrides:
# This was only intended for ghc-7.0.4, and has very old deps, one hidden behind a flag
- MissingH ==1.4.2.0
# gi-gdkx11-4.x requires gtk-4.x, which is still under development and
# not yet available in Nixpkgs
- gi-gdkx11 < 4
- shelly ==1.8.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be here, but instead in the extra-packages section below.

We don't want to force the haskellPackages.shelly derivation to be version 1.8.1, but instead we want to generate a haskellPackages.shelly_1_8_1 derivation in addition.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I have made this change and pushed.

@dhruvio
Copy link
Contributor Author

dhruvio commented Aug 25, 2020

@maralorn Thanks for the instructions. I have followed them, and can confirm that GHCJS is building successfully. I was able to compile a simple main = putStrLn "hello, world." program and run it successfully.

@cdepillabout
Copy link
Member

This looks good to me.

@dhruvio Thanks for fixing this up.

cc @peti so he is aware of this change as well.

@cdepillabout cdepillabout merged commit 1fc3d9f into NixOS:haskell-updates Aug 26, 2020
@dhruvio
Copy link
Contributor Author

dhruvio commented Aug 26, 2020

Thanks for your help @cdepillabout and @maralorn !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants