Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slackcat: init at 1.6 #96222

Closed
wants to merge 3 commits into from
Closed

slackcat: init at 1.6 #96222

wants to merge 3 commits into from

Conversation

nasadorian
Copy link

@nasadorian nasadorian commented Aug 25, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nasadorian
Copy link
Author

@GrahamcOfBorg How can I get this PR merged?

dali99
dali99 suggested changes Sep 4, 2020
View reviewed changes
Copy link
Member

@dali99 dali99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All packages need meta information

@nasadorian
Copy link
Author

nasadorian commented Sep 4, 2020 •
edited

@dali99 Thanks for your review. Do I need to add myself as a maintainer or the package developer themself?

@dali99
Copy link
Member

dali99 commented Sep 4, 2020

@dali99 Thanks for your review. Do I need to add myself as a maintainer or the package developer themself?

You add yourself

For more information you can read
https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md and the linked guides in it 😃

In your case you should have two commits
One adding you to the maintainers list

maintainers: add nasadorian

With the relevant information to maintainers/maintainer-list.nix

The other commit should be

slackcat: init at 1.6

adding the package itself.

There should be no more commits (so you need to force push your branch)

@dali99
Copy link
Member

dali99 commented Sep 5, 2020

You seem to have based your PR on a branch from May in 2019

The maintainers/maintainer-list.nix has changed since then, mainly including a githubId.

nix
    handle = {
      # Required
      name = "Your name";
      email = "address@example.org";
      # Optional
      github = "GithubUsername";
      githubId = your-github-id;
      keys = [{
        longkeyid = "rsa2048/0x0123456789ABCDEF";
        fingerprint = "AAAA BBBB CCCC DDDD EEEE  FFFF 0000 1111 2222 3333";
      }];
    };

Just commenting so that you'll be aware of this. I'd rebase on current master and add at least githubId

@nasadorian
slackcat: init at 1.6
c8bdb8e 
add callPackage

minor refactor of rev

Update pkgs/tools/networking/slackcat/default.nix

Co-authored-by: Daniel Løvbrøtte Olsen <daniel.olsen99+GitHub@gmail.com>

slackcat: init at 1.6
@nasadorian
maintainers: add nasadorian
b8996cb 
maintainers: add nasadorian
dali99
dali99 approved these changes Sep 5, 2020
View reviewed changes
Copy link
Member

@dali99 dali99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built sucessfully!

🎉

@nasadorian
Copy link
Author

@dali99 Is there a way to kick the build? I'm not sure what happened here.

@dali99
Copy link
Member

dali99 commented Sep 16, 2020

ah yes we should ping someone
@jonringer ?

@pbogdan
Copy link
Member

pbogdan commented Sep 16, 2020

@GrahamcOfBorg eval

@nasadorian
Copy link
Author

Boom passes! Thanks @dali99 @pbogdan

@nasadorian
Copy link
Author

Hi guys, how can I get this PR merged? @dali99 @pbogdan

@nasadorian @SuperSandro2000
Update pkgs/tools/networking/slackcat/default.nix
661129c 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
jonringer
jonringer reviewed Nov 29, 2020
View reviewed changes
pkgs/tools/networking/slackcat/default.nix
Comment on lines +8 to +12
owner = "bcicen";
repo = "${pname}";
rev = "v${version}";
sha256 = "1ha9b2dffpxqs159ldqdh1aibn3316xab19vdn2yjgk8r508wm31";
};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed they have a go.mod https://github.com/bcicen/slackcat/blob/0b70f6e0ab9c41e4782bfbe74e934ddb49d520b8/go.mod, do you mind trying to do a buildGoModule instead? package is deprecated

pkgs/tools/networking/slackcat/default.nix

src = fetchFromGitHub {
owner = "bcicen";
repo = "${pname}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
repo = "${pname}";
repo = pname;

@jonringer
Copy link
Contributor

Please follow CONTRIBUTING.md and manual#submitting-changes-making-patches and squash the fix-up commits.

git rebase -i is a powerful command which achieves this, I created a small video demonstrating it's use here. A more indepth text tutorial can be found here

SuperSandro2000
SuperSandro2000 requested changes Dec 8, 2020
View reviewed changes
pkgs/tools/networking/slackcat/default.nix
@@ -0,0 +1,22 @@
{ stdenv, buildGoPackage, fetchFromGitHub }:

buildGoPackage rec {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use buildGoModule which does not require use to use a deps.nix.

@stale
Copy link

stale bot commented Jul 19, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 19, 2021
@SuperSandro2000
Copy link
Member

Closing due to inactivity from author.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 requested changes

@dali99 dali99 dali99 approved these changes

Assignees
No one assigned
Labels
2.status: merge conflict 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nasadorian @dali99 @pbogdan @jonringer @SuperSandro2000