python3Packages.trezor: 0.12.1 -> 0.12.2 #96257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prusnak
changed the title
1000101
approved these changes
Aug 27, 2020
There was a problem hiding this comment.
- reviewed the diff and commit messages
- made sure ofBorg build succeeded for all applicable platforms
- ran and tested the binaries
- ran nix-review without any failures
builder for '/nix/store/rsfz9s74znmjzm7fmpvj117s9j3vzj8d-electron-cash-4.0.14.drv' failed with exit code 1; last 10 log lines:
/build/source/dist /build/source
Processing ./Electron_Cash-4.0.14-py3-none-any.whl
...
ERROR: Could not find a version that satisfies the requirement protobuf<3.9 (from Electron-Cash==4.0.14) (from versions: none)
ERROR: No matching distribution found for protobuf<3.9 (from Electron-Cash==4.0.14)
builder for '/nix/store/fpi35mhypijbsb040rq05flwa0wn5jhn-electrum-4.0.2.drv' failed with exit code 1; last 10 log lines:
ERROR: Could not find a version that satisfies the requirement dnspython<2.0 (from Electrum==4.0.2) (from versions: none)
ERROR: No matching distribution found for dnspython<2.0 (from Electrum==4.0.2)
...
2 packages failed to build:
electron-cash electrum
Packages electron-cash and electrum seems to be failing but not due to this PR.
|
@GrahamcOfBorg build python3Packages.trezor |
|
Reported the |
|
@GrahamcOfBorg build python3Packages.trezor |
+ add attrs, pillow to dependencies
|
@GrahamcOfBorg build python3Packages.trezor |
1000101
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)