Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

so: init at 0.4.2 #96540

Merged
merged 1 commit into from Aug 30, 2020
Merged

so: init at 0.4.2 #96540

merged 1 commit into from Aug 30, 2020

Conversation

mredaelli
Copy link
Contributor

Motivation for this change

New package

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Kloenk
Copy link
Member

Kloenk commented Aug 28, 2020

Builds, Works, (looks interesting).
LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/210

danieldk
danieldk suggested changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small requested change, looks good otherwise.

pkgs/development/tools/so/default.nix Outdated Show resolved Hide resolved
@mredaelli mredaelli requested a review from andir as a code owner August 29, 2020 12:59
@ofborg ofborg bot added the 6.topic: rust label Aug 29, 2020
@danieldk
Copy link
Contributor

Seems like something went wrong with rebasing? There are three additional commits.

@mredaelli
Copy link
Contributor Author

Sorry, no idea why.

Should be fixed

@ofborg ofborg bot removed the 6.topic: rust label Aug 29, 2020
@danieldk
Copy link
Contributor

Should be fixed

Thanks a lot for the fixes! I missed one thing in my review yesterday, we usually take specific frameworks as an argument (e.g. Security) rather than darwin. This e.g. makes it easier for downstream users to override such frameworks. I have amended the commit to fix this. Once ofborg is happy, this PR should be good to go.

@danieldk danieldk merged commit ff875a9 into NixOS:master Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@andir andir Awaiting requested review from andir

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mredaelli @Kloenk @nixos-discourse @danieldk