Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.cryptography: 3.0 -> 3.1 #96541

Merged
merged 1 commit into from Aug 29, 2020
Merged

python3Packages.cryptography: 3.0 -> 3.1 #96541

merged 1 commit into from Aug 29, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Aug 28, 2020

Backwards incompatible changes:

  • Removed support for idna based U-label parsing in various X.509
    classes. This support was originally deprecated in version 2.1 and
    moved to an extra in 2.5.
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
python3Packages.cryptography: 3.0 -> 3.1
b426d03 
Backwards incompatible changes:
- Removed support for idna based U-label parsing in various X.509
  classes. This support was originally deprecated in version 2.1 and
  moved to an extra in 2.5.
@seppeljordan
Copy link
Contributor

With flakes enabled I executed nix build .#python3Packages.cryptography and nix build .#python2Packages.cryptography and both build processes finished successfully.

@FRidh FRidh merged commit 16ecb02 into NixOS:staging Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@primeos @seppeljordan @FRidh