Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

noaa-apt: init at 1.2.0 #96519

Merged
merged 1 commit into from Aug 29, 2020
Merged

noaa-apt: init at 1.2.0 #96519

merged 1 commit into from Aug 29, 2020

Conversation

trepetti
Copy link
Contributor

Motivation for this change

noaa-apt is decoding software that enables the conversion of audio recordings of NOAA weather satellite APT protocol transmissions into a variety of image formats. Typically this recording is done using software defined radios (SDRs) like RTLSDR, HackRF, etc., which are already well supported in Nix. This software would complement the growing suite of SDR tools.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@trepetti
Copy link
Contributor Author

/marvin opt-in
/status needs_reviewer

@marvin-mk2
Copy link

marvin-mk2 bot commented Aug 28, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/278

danieldk
danieldk suggested changes Aug 29, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I added a number of small requested changes.

pkgs/applications/radio/noaa-apt/default.nix Outdated Show resolved Hide resolved
pkgs/applications/radio/noaa-apt/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/applications/radio/noaa-apt/default.nix Outdated Show resolved Hide resolved
pkgs/applications/radio/noaa-apt/default.nix Outdated Show resolved Hide resolved
pkgs/applications/radio/noaa-apt/default.nix Show resolved Hide resolved
@trepetti trepetti requested a review from danieldk August 29, 2020 14:38
@trepetti
Copy link
Contributor Author

Thank you for your review! I believe this covers all those fixes.

danieldk
danieldk approved these changes Aug 29, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making all the changes!

Result of nixpkgs-review pr 96519 1

1 package built:
- noaa-apt

@danieldk danieldk merged commit d37baf7 into NixOS:master Aug 29, 2020
@trepetti trepetti deleted the noaa-apt branch August 29, 2020 15:17
@trepetti trepetti mentioned this pull request Oct 9, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@trepetti @nixos-discourse @danieldk