Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.wasabi: 0.7.1 -> 0.8.0 #96464

Merged
merged 1 commit into from Aug 27, 2020
Merged

python3Packages.wasabi: 0.7.1 -> 0.8.0 #96464

merged 1 commit into from Aug 27, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
Copy link
Contributor Author

@ofborg build python37Packages.spacy python38Packages.spacy

drewrisinger
drewrisinger approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff mostly LGTM. Suggestions would be to add a changelog and switch to pytestCheckHook, but not required.
  • Commits LGTM.
  • Builds via nix-review
9 packages built:
python27Packages.wasabi python37Packages.spacy python37Packages.textacy python37Packages.thinc python37Packages.wasabi python38Packages.spacy python38Packages.textacy python38Packages.thinc python38Packages.wasabi

@danieldk
Copy link
Contributor Author 

* [x]  Diff mostly LGTM. Suggestions would be to add a changelog and switch to `pytestCheckHook`, but not required.

Version bumps are always a good excuse to add other improvements, so switched to pytestCheckHook and added meta.changelog. The commit message now also has a pointer to the changelog item.

Thanks for the comments!

@danieldk
python3Packages.wasabi: 0.7.1 -> 0.8.0
193c4fd 
Changelog:
https://github.com/ines/wasabi/releases/tag/v0.8.0

While at it:

- Use pytestCheckHook;
- add meta.changelog.
drewrisinger
drewrisinger approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits LGTM
  • Builds via nix-review:
https://github.com/NixOS/nixpkgs/pull/96464
9 packages built:
python27Packages.wasabi python37Packages.spacy python37Packages.textacy python37Packages.thinc python37Packages.wasabi python38Packages.spacy python38Packages.textacy python38Packages.thinc python38Packages.wasabi

jonringer
jonringer approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 96464 1

9 packages built:
- python27Packages.wasabi
- python37Packages.spacy
- python37Packages.textacy
- python37Packages.thinc
- python37Packages.wasabi
- python38Packages.spacy
- python38Packages.textacy
- python38Packages.thinc
- python38Packages.wasabi

@jonringer jonringer merged commit 5950b49 into NixOS:master Aug 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@drewrisinger drewrisinger drewrisinger approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @jonringer @drewrisinger