New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linuxPackages.system76, system76-acpi, system76-io: init at 1.0.x #96514
Conversation
Sorry to ping you again @stites, but we would like to add the System76 drivers to Nixpkgs instead. Can I ask for your okay on relicensing from BSD-3 to MIT please? |
BSD-3 and MIT is compatible. We only need MIT/BSD-3 for nix expressions the patches itself can have a different license. |
Okay, I've applied all of your suggestions, thanks for the feedback. I did some other clean-up and edits for consistency with other module expressions too:
Yes, just talking about the expressions. I wasn't sure if BSD-3 work could be included in MIT work, since that requires removing the advertising clause. |
According to
I would add something like to each affected package
(assuming that this driver does not make sense on aarch64 anyway). |
Good point. I've blacklisted them for versions below 4.14, since that's the lowest version in Nixpkgs that builds. After remembering to remove Is the aarch64 check necessary? I've only listed i686 and x86_64 as supported platforms. |
This is a bug in nix-review that was fixed recently. |
@GrahamcOfBorg eval |
@khumba Do you know how to tell if your system76 device needs these modules? Do they come with udev rules or do you need to explicitly load them? |
@shlevy They just need to be added as kernel modules to NixOS. This nixos-hardware module does it: NixOS/nixos-hardware#186 |
Motivation for this change
This adds System76's kernel modules to Nixpkgs. These modules provide support for hardware in System76 computers, enabling multimedia keys and keyboard backlight keys. This is split off from a PR of mine in the nixos-hardware repo here, to move the drivers into Nixpkgs itself.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)