Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.spotipy: fix build #96489

Merged
merged 1 commit into from Aug 28, 2020
Merged

pythonPackages.spotipy: fix build #96489

merged 1 commit into from Aug 28, 2020

Conversation

georgewhewell
Copy link
Contributor

Motivation for this change

spotipy does not build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@georgewhewell georgewhewell changed the title spotipy: fix build pythonPackages.spotipy: fix build Aug 27, 2020
jonringer
jonringer reviewed Aug 27, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no tests included. Please try to checkout from source and check if they have unit tests, and try to run them. Unit tests give a good indication that they package has a high degree of validity and correctness given the python package set.

If tests are not available, then please use pythonImportsCheck to import the most important modules. This isn't as good as unit tests, but will usually give a good indication of run-time errors. Please see pythonImportsCheck documentation for more information.


----------------------------------------------------------------------
Ran 0 tests in 0.000s

@georgewhewell
Copy link
Contributor Author

thanks. the existing package did not run tests either, i only fix the build. tests cannot be run because they are deleted by pythonRemoveTestsDir. i have added pythonImportsCheck and it passes

jonringer
jonringer approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 96489 1

3 packages built:
- python27Packages.spotipy
- python37Packages.spotipy
- python38Packages.spotipy

@jonringer jonringer merged commit 4725db6 into NixOS:master Aug 28, 2020
@georgewhewell georgewhewell deleted the fix-pyspotify branch August 28, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@georgewhewell @jonringer