Revert "buildGoPackage: remove references in $out/libexec" #96534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b9ac86e.
|
Why not remove the |
|
It's just noise in the build output of |
Mic92
reviewed
Aug 28, 2020
| @@ -212,7 +212,6 @@ let | |||
|
|
|||
| preFixup = preFixup + '' | |||
| find $out/bin -type f -exec ${removeExpr removeReferences} '{}' + || true | |||
| find $out/libexec -type f -exec ${removeExpr removeReferences} '{}' + || true | |||
There was a problem hiding this comment.
less noise:
find $out/{bin,libexec} -type f 2>/dev/null | xargs -r -n 1 ${removeExpr removeReferences} || true
|
I'd rather just revert it TBH as it isn't useful. Also it doesn't match |
Two packages we are aware of. The issue I see that this silently breaks cross-compilation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b9ac86e.
Added in #92140 for docker which already has this:
nixpkgs/pkgs/applications/virtualization/docker/default.nix
Lines 182 to 186 in 22c23f4