Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faust: fixup and upgrade #96491

Merged
merged 2 commits into from Aug 27, 2020
Merged

Faust: fixup and upgrade #96491

merged 2 commits into from Aug 27, 2020

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Aug 27, 2020 •
edited

Motivation for this change

Fixes build errors like these.

Since we are currently on an unstable release of faust because of a bug in stable, I figured we might as well upgrade and get better diagnostics for some slow build issues I've been having.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from pmahoney August 27, 2020 20:16
@Lassulus
Copy link
Member

Result of nixpkgs-review pr 96491 1

3 packages failed to build:
- faustlive
- foo-yc20
- purePackages.faust
12 packages built:
- faust
- faust2alqt
- faust2alsa
- faust2csound
- faust2firefox
- faust2jack
- faust2jackrust
- faust2jaqt
- faust2ladspa
- faust2lv2
- kapitonov-plugins-pack
- tambura

@Lassulus
Copy link
Member

they are either broken on master anyway or marked as broken

@Lassulus Lassulus merged commit eef944c into NixOS:master Aug 27, 2020
@magnetophon
Copy link
Member Author

Thanks!

@magnetophon magnetophon deleted the faust branch August 27, 2020 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmahoney pmahoney Awaiting requested review from pmahoney

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magnetophon @Lassulus