Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildGoModule/buildGoPackage: Remove go references from lib,libexec #96538

Merged
merged 7 commits into from Aug 30, 2020
Merged

buildGoModule/buildGoPackage: Remove go references from lib,libexec #96538

merged 7 commits into from Aug 30, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Aug 28, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 mentioned this pull request Aug 28, 2020
Closed
@zowoq
Copy link
Contributor

zowoq commented Aug 28, 2020 •
edited

buildGoModule? Nothing uses libexec.

@Mic92 Mic92 force-pushed the go-references branch 2 times, most recently from 11bc594 to 4e33390 Compare August 28, 2020 12:10
@zowoq
Copy link
Contributor

zowoq commented Aug 28, 2020

If we're doing this we may as well do sbin and lib.

@zowoq
Copy link
Contributor

zowoq commented Aug 28, 2020

Also:

nixpkgs/pkgs/applications/virtualization/singularity/default.nix

Line 71 in 6eae50c

find $out/libexec/ -type f -executable -exec remove-references-to -t ${go} '{}' + || true

@Mic92
Copy link
Member Author

Mic92 commented Aug 28, 2020 •
edited

If we're doing this we may as well do sbin and lib.

I checked sbin but it is already moved in fixupPhase to bin, so I left it. I added lib

@Mic92
Copy link
Member Author

Mic92 commented Aug 28, 2020

Also:

nixpkgs/pkgs/applications/virtualization/singularity/default.nix

Line 71 in 6eae50c

find $out/libexec/ -type f -executable -exec remove-references-to -t ${go} '{}' + || true

done

@Mic92
Copy link
Member Author

Mic92 commented Aug 28, 2020

buildGoModule? Nothing uses libexec.

Eventually docker and co could be migrated to it at which point it will be used.

@Mic92
Copy link
Member Author

Mic92 commented Aug 28, 2020

There is also the deepin desktop (~ 3 packages) that could make use of it but it is marked as broken atm.

@zowoq
Copy link
Contributor

zowoq commented Aug 28, 2020

There is also the deepin desktop (~ 3 packages) that could make use of it but it is marked as broken atm.

I'd include them anyway.

@Mic92
Copy link
Member Author

Mic92 commented Aug 28, 2020

done.

@Mic92 Mic92 changed the title Go references buildGoModule/buildGoPackage: Remove go references Aug 28, 2020
@Mic92 Mic92 changed the title buildGoModule/buildGoPackage: Remove go references buildGoModule/buildGoPackage: Remove go references from lib,libexec Aug 28, 2020
@Mic92
Copy link
Member Author

Mic92 commented Aug 28, 2020

All good?

@lheckemann lheckemann merged commit bba8571 into NixOS:master Aug 30, 2020
@Mic92 Mic92 deleted the go-references branch August 30, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit kalbasit approved these changes

@lheckemann lheckemann lheckemann approved these changes

@zowoq zowoq zowoq approved these changes

Assignees
No one assigned
Labels
6.topic: golang 8.has: documentation 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @zowoq @kalbasit @lheckemann