Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

haste-client: Init at 0.2.3 #96536

Merged
merged 1 commit into from Jan 18, 2021
Merged

Conversation

SCOTT-HAMILTON
Copy link
Contributor

Motivation for this change

#86041

Things done

Packaged haste-client at release 0.2.3.
This seems a bit unmaintained and a few warnings are given at runtime but it still works and it is quite useful to share code on IRC.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@evils
Copy link
Member

evils commented Aug 30, 2020

while the warnings are annoying
it works for me, thanks

@SuperSandro2000
Copy link
Member

This is a semi-automatic executed nixpkgs-review which is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).
If you have any questions or problems please reach out to SuperSandro2000 on IRC.

Result of nixpkgs-review pr 96536 run on x86_64-linux 1

1 package built:
  • haste-client

@SuperSandro2000 SuperSandro2000 merged commit 0939b6d into NixOS:master Jan 18, 2021
@ajs124
Copy link
Member

ajs124 commented Jan 19, 2021

The tarball job on unstable-small is broken right now and a git bisect points me to this PR.

@puckipedia
Copy link
Contributor

I believe the issue is the use of the bundlerEnv as a propagated build input, which no other package does. I believe it should be replaced with a bundlerApp usage, which seems to be what @SCOTT-HAMILTON intended, without silently breaking a piece of infrastructure way higher up.

@SCOTT-HAMILTON
Copy link
Contributor Author

Fixing it, BTW haste servers seems to be dead right now.

@puckipedia
Copy link
Contributor

Awesome, I'd suggest looking at https://github.com/NixOS/nixpkgs/blob/master/doc/languages-frameworks/ruby.section.md#packaging-applications for the best way to solve it :p

@SCOTT-HAMILTON
Copy link
Contributor Author

Should fix it : #110006

@SuperSandro2000
Copy link
Member

Fixing it, BTW haste servers seems to be dead right now.

maybe I did not get rate limited but it is down. Interesting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants