switch from sass to less (css) #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hmaurer we kinda have to use yarn since only yarn2nix exists. there is also npm2nix but that requires us to generate nix file and not just reading the lock file. We can switch once situation changes there. There is also I tested this locally and works fine! |
|
@garbas ah! just to be clear: I wasn't suggesting switching to NPM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the CSS preprocessor from https://sass-lang.com/ to http://lesscss.org/. This resolves an issue with
node-sasson OS X (#157) and will facilitate integration with NixOS/nixos-homepage#506.I'd appreciate a careful review of the Nix side of these changes. I removed a chunk of code from
default.nixwhich appeared to be customisingnode-sass, but I don't know if something similar is necessary forless. Everything appears to work as expected, though.PS: question to @garbas (or another contributor): how do you generate
yarn.lockafter making changes topackage.json? Yarn does not seem to have a flag to generate a lock file only, so I've been runningyarn install && rm -r node_modules. Is there another way?If you don't already have a better solution in place we could add a command to the nix shell using
npm --package-lock-onlyand https://github.com/imsnif/synp, c.f. https://stackoverflow.com/a/58609139/2362799