New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dot-http: init at 0.2.0 #96537
dot-http: init at 0.2.0 #96537
Conversation
ea03064
to
8080224
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some small changes to make the derivation more canonical.
@danieldk thank you for the review! Can I use this (new?) "commit suggestion" feature and then you squash the commits, of is it better if I mirror them locally and rebase? Or any other workflow that's easiest for you (I mean, if you can and want commit them yourself from here, I'm more than happy). |
It's best to mirror them locally, but you should be able to get best from both worlds. First use the commit suggestions in the GitHub interface, then something like:
|
Will do, thanks. Just wanted to make sure I'm not going to drive CI jobs crazy :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)