Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dot-http: init at 0.2.0 #96537

Merged
merged 1 commit into from Aug 29, 2020
Merged

dot-http: init at 0.2.0 #96537

merged 1 commit into from Aug 29, 2020

Conversation

mredaelli
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some small changes to make the derivation more canonical.

pkgs/development/tools/dot-http/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/dot-http/default.nix Outdated Show resolved Hide resolved
pkgs/development/tools/dot-http/default.nix Outdated Show resolved Hide resolved
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@mredaelli
Copy link
Contributor Author

@danieldk thank you for the review!

Can I use this (new?) "commit suggestion" feature and then you squash the commits, of is it better if I mirror them locally and rebase?

Or any other workflow that's easiest for you (I mean, if you can and want commit them yourself from here, I'm more than happy).

@danieldk
Copy link
Contributor

Can I use this (new?) "commit suggestion" feature and then you squash the commits, of is it better if I mirror them locally and rebase?

It's best to mirror them locally, but you should be able to get best from both worlds. First use the commit suggestions in the GitHub interface, then something like:

$ git pull --rebase
$ git rebase -i master
# Mark everything but the first commit squash, save and quit
$ git log # Verify that the history looks ok
$ git push -f

@mredaelli
Copy link
Contributor Author

Will do, thanks. Just wanted to make sure I'm not going to drive CI jobs crazy :)

Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks a lot!

Result of nixpkgs-review pr 96537 1

1 package built:
- dot-http

@danieldk danieldk merged commit 7a29b43 into NixOS:master Aug 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants