Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tunefish: init at unstable 2020-08-13 #96539

Merged
merged 1 commit into from Sep 2, 2020
Merged

tunefish: init at unstable 2020-08-13 #96539

merged 1 commit into from Sep 2, 2020

Conversation

orivej
Copy link
Contributor

@orivej orivej commented Aug 28, 2020

Motivation for this change

A good sounding synth with thousand presets.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc @magnetophon

@magnetophon
Copy link
Member

@orivej Great, I've been meaning to package this one too.
Thank you!

It is building as we speak.
I might not be able to report back until tomorrow though.

@orivej
tunefish: init at unstable 2020-08-13
5f9cef0 
Fails to build on aarch64 due to the use of x86 intrinsics.
@magnetophon
Copy link
Member

I get:

builder for '/nix/store/26m9x2m0imflbfpq0cvbf0p6lckwiv93-webkitgtk-2.28.4.drv' failed with exit code 1; last 10 log lines:
  clang-7: error: clang frontend command failed due to signal (use -v to see invocation)
  clang version 7.1.0 (tags/RELEASE_710/final)
  Target: x86_64-unknown-linux-gnu
  Thread model: posix
  InstalledDir: /nix/store/dkd18vj3sbbigpii1kdgg0qlz4d3yj1k-clang-7.1.0/bin
  clang-7: note: diagnostic msg: PLEASE submit a bug report to  and include the crash backtrace, preprocessed source, and associated run script.
  clang-7: error: unable to execute command: Segmentation fault
  clang-7: note: diagnostic msg: Error generating preprocessed source(s).
  ninja: build stopped: subcommand failed.
  builder for '/nix/store/26m9x2m0imflbfpq0cvbf0p6lckwiv93-webkitgtk-2.28.4.drv' failed with exit code 1
cannot build derivation '/nix/store/ddx8783l86hsrgpnpclsf5zjj9dsbzf4-tunefish-unstable-2020-08-13.drv': 1 dependencies couldn't be built

@orivej
Copy link
Contributor Author

orivej commented Aug 30, 2020

In case a PR requires you to build more than it changes you can test it on top of your current system, with something like this in the checkout of the PR:

$ cat /run/current-system/nixos-version
20.09.git.48ef8562f2a
$ git rebase --onto 48ef8562f2a HEAD^ HEAD

@magnetophon
Copy link
Member

@orivej Thanks, that is very handy.
How do I check out the PR though?
There must be an easier way than adding your branch as a remote and pulling from that, right?

@orivej
Copy link
Contributor Author

orivej commented Aug 30, 2020

I am using a custom tool gh (that I did not mean to publish and hence named it with the shortest unused name) that checks out a PR with just gh edit 96539.

@orivej
Copy link
Contributor Author

orivej commented Sep 2, 2020

I'm going to merge it because it works well for me.

@orivej-nixos orivej-nixos merged commit 3db58a2 into NixOS:master Sep 2, 2020
@magnetophon
Copy link
Member

Sorry for not testing, thanks for the package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@orivej @magnetophon @orivej-nixos