New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebKitGTK: rework how the minibrowser is downloaded on the CI (TaskCluster) and add weekly runs for beta channel #25263
WebKitGTK: rework how the minibrowser is downloaded on the CI (TaskCluster) and add weekly runs for beta channel #25263
Conversation
ddb1425
to
fb516a5
Compare
ping reviewers? //cc @jgraham |
Pushed a new commit changing:
Please let me know if more changes are needed. Thanks! |
BTW.. I see 3 checks on the CI failed after the last fix-up commit (just a change on the pattern of the sha256checksum files) to accommodate to a recent upstream webkit change. I don't think this 3 failures are valid.. after checking the log that seems to me like some random failure on that CI machines. |
f197073
to
e3219cf
Compare
…atform-tests#25263) * Until now, when running the WebKitGTK tests on the taskcluster CI a pre-running hook was triggerred that installed some custom Debian packages for the stable channel and unpacked a tarball for the nightly channel. The tarball from the nightly channel required to install a lot of extra (uneeeded) dependencies (it was not optimized) slowing down the CI tests. * We recently re-worked how the pre-built products are generated, now we provide built products for stable, beta and nightly using the same bundle type: a zip file that contains just webkitgtk with the minimum libraries needed for it and is built for the target operating system where it will run. Currently we support Ubuntu LTS and LTS-1. TC CI runs in Ubuntu LTS. * This patch add supports for the command "wpt --install-browser" for product webkitgtk_minibrowser and uses this command to install the browser on the CI. The built product downloaded not longer requires using a specific path and is unpacked in the local directory. * This also means end-users can also install webkitgtk via this way and use it. But currently it will only work for them if they run Ubuntu LTS. We may add support for more distros in the future. * Finally this commit also schedules weekly webkitgtk_minibrowser runs for the beta channel on the CI.
Sorry for the late replies, I was on holidays this past weeks.
|
The failure on the CI seems unrelated to this commit. I tracked it down to be caused by #25774 (comment) |
…atform-tests#25263) * Until now, when running the WebKitGTK tests on the taskcluster CI a pre-running hook was triggerred that installed some custom Debian packages for the stable channel and unpacked a tarball for the nightly channel. The tarball from the nightly channel required to install a lot of extra (uneeeded) dependencies (it was not optimized) slowing down the CI tests. * We recently re-worked how the pre-built products are generated, now we provide built products for stable, beta and nightly using the same bundle type: a zip file that contains just webkitgtk with the minimum libraries needed for it and is built for the target operating system where it will run. Currently we support Ubuntu LTS and LTS-1. TC CI runs in Ubuntu LTS. * This patch add supports for the command "wpt --install-browser" for product webkitgtk_minibrowser and uses this command to install the browser on the CI. The built product downloaded not longer requires using a specific path and is unpacked in the local directory. * This also means end-users can also install webkitgtk via this way and use it. But currently it will only work for them if they run Ubuntu LTS. We may add support for more distros in the future. * Finally this commit also schedules weekly webkitgtk_minibrowser runs for the beta channel on the CI.
e3219cf
to
5990ad0
Compare
Rebased again on top of master to avoid the unrelated failure on the CI |
Everything green on the CI now |
Thanks! |
…atform-tests#25263) * Until now, when running the WebKitGTK tests on the taskcluster CI a pre-running hook was triggerred that installed some custom Debian packages for the stable channel and unpacked a tarball for the nightly channel. The tarball from the nightly channel required to install a lot of extra (uneeeded) dependencies (it was not optimized) slowing down the CI tests. * We recently re-worked how the pre-built products are generated, now we provide built products for stable, beta and nightly using the same bundle type: a zip file that contains just webkitgtk with the minimum libraries needed for it and is built for the target operating system where it will run. Currently we support Ubuntu LTS and LTS-1. TC CI runs in Ubuntu LTS. * This patch add supports for the command "wpt --install-browser" for product webkitgtk_minibrowser and uses this command to install the browser on the CI. The built product downloaded not longer requires using a specific path and is unpacked in the local directory. * This also means end-users can also install webkitgtk via this way and use it. But currently it will only work for them if they run Ubuntu LTS. We may add support for more distros in the future. * Finally this commit also schedules weekly webkitgtk_minibrowser runs for the beta channel on the CI.
Until now, when running the WebKitGTK tests on the taskcluster CI a pre-running hook was triggerred that installed some custom Debian packages for the stable channel and unpacked a tarball for the nightly channel. The tarball from the nightly channel required to install a lot of extra (uneeeded) dependencies (it was not optimized) slowing down the CI tests.
We recently re-worked how the pre-built products are generated, now we provide built products for stable, beta and nightly using the same bundle type: a zip file that contains just webkitgtk with the minimum libraries needed for it and is built for the target operating system where it will run. Currently we support Ubuntu LTS and LTS-1. TC CI runs in Ubuntu LTS.
This patch add supports for the command
wpt --install-browser
for productwebkitgtk_minibrowser
and uses this command to install the browser on the CI. The built product downloaded not longer requires using a specific path and is unpacked in the local directory.This also means end-users can also install webkitgtk via this way and use it. But currently it will only work for them if they run Ubuntu LTS. We may add support for more distros in the future.
This patch also adds weekly runs for the beta channel.
The built products are available at https://webkitgtk.org/built-products/x86_64/release and automatic bots generate them daily.
The bots generating the built products for the nightly channel are at https://build.webkit.org and the ones for the stable and beta channels at https://build-webkit.igalia.com