Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.cvxpy: 1.1.4 -> 1.1.5 #96468

Merged
merged 1 commit into from Aug 28, 2020
Merged

python3Packages.cvxpy: 1.1.4 -> 1.1.5 #96468

merged 1 commit into from Aug 28, 2020

Conversation

drewrisinger
Copy link
Contributor

@drewrisinger drewrisinger commented Aug 27, 2020 •
edited

Motivation for this change

Update to latest version of python3Packages.cvxpy: https://github.com/cvxgrp/cvxpy/releases/tag/v1.1.5

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@drewrisinger drewrisinger force-pushed the dr-pr-cvxpy branch 2 times, most recently from e38eebe to c54d5f3 Compare August 27, 2020 14:16
@drewrisinger
python3Packages.cvxpy: 1.1.4 -> 1.1.5
6b51154 
Changelog: https://github.com/cvxgrp/cvxpy/releases/tag/v1.1.5

Other updates:
    * Update to pytestCheckHook
    * Disable slowest tests
    * Add changelog
@drewrisinger drewrisinger marked this pull request as ready for review August 27, 2020 14:26
jonringer
jonringer approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 96468 1

12 packages built:
- python37Packages.cvxpy
- python37Packages.qasm2image
- python37Packages.qiskit
- python37Packages.qiskit-aer
- python37Packages.qiskit-aqua
- python37Packages.qiskit-ignis
- python38Packages.cvxpy
- python38Packages.qasm2image
- python38Packages.qiskit
- python38Packages.qiskit-aer
- python38Packages.qiskit-aqua
- python38Packages.qiskit-ignis

@jonringer jonringer merged commit b72fd5c into NixOS:master Aug 28, 2020
@drewrisinger drewrisinger deleted the dr-pr-cvxpy branch October 8, 2020 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@danieldk danieldk Awaiting requested review from danieldk

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drewrisinger @jonringer