Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expo-cli: init + implement overrideNodeAttrs #96509

Merged
merged 2 commits into from Oct 7, 2020
Merged

expo-cli: init + implement overrideNodeAttrs #96509

merged 2 commits into from Oct 7, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Aug 27, 2020 •
edited

Motivation for this change

Closes: #93399

Had to implement overrideNodeAttrs to filter out optional @expo/traveling-fastlane-darwin dependency that was intentionally aborting the build on Linux.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • Successfully ran react-native app on Android using this
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
Copy link
Contributor Author

jtojnar commented Aug 27, 2020

cc @FRidh who implemented overridePythonAttrs I based this on

cc @Scriptkiddi who was also interested in this

@FRidh
Copy link
Member

FRidh commented Aug 28, 2020

While I am not sure whether it is the correct direction to add these language/framework-specific overrides (see NixOS/rfcs#67 (comment)) I do think the implementation in #87394 would be preferred over us implementing our own ones every time.

@jtojnar
Copy link
Contributor Author

jtojnar commented Aug 28, 2020

Thanks, I was trying to find the PR but did not realize it was closed. I agree with you but in the meantime I would like a working, if only temporary solution.

What do you think about gating it on explicit acknowledgement that the function can be dropped at any time?

@FRidh
Copy link
Member

FRidh commented Aug 29, 2020 •
edited

Well, I say we should just use that PR. Having those override functions does not preclude having a common override function which I proposed (that could be say overrideArgs).

@ofborg ofborg bot requested a review from midchildan October 7, 2020 19:28
@jtojnar
Copy link
Contributor Author

jtojnar commented Oct 7, 2020

I think I will use the local internal function for now, rather than switching to a public API that would be deprecated after RFC 67. I will port to that once it gets accepted.

@jtojnar jtojnar merged commit b762081 into NixOS:master Oct 7, 2020
@jtojnar jtojnar deleted the expo-cli branch October 7, 2020 19:35
@oxalica oxalica mentioned this pull request Oct 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@midchildan midchildan Awaiting requested review from midchildan

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Packaging request: expo
3 participants
@jtojnar @FRidh @ryantm