Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.jupyterhub-tmpauthenticator: init at 0.6 #96475

Merged
merged 1 commit into from Aug 28, 2020
Merged

pythonPackages.jupyterhub-tmpauthenticator: init at 0.6 #96475

merged 1 commit into from Aug 28, 2020

Conversation

chiroptical
Copy link
Contributor

Motivation for this change

This package provides a JupyterHub authenticator that allows any user to log in to JupyterHub. The package doesn't provide any tests and therefore I use pythonImportsCheck.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed Aug 28, 2020
View reviewed changes
pkgs/development/python-modules/jupyterhub-tmpauthenticator/default.nix

propagatedBuildInputs = [ jupyterhub ];

doCheck = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please give a comment as to why they were disabled.

I'm assuming either network or difficult to test. Either way, should give a reason.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package doesn't actually provide any tests so I figured there is no reason to run the check phase. I'll add a comment to the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment added.

jonringer
jonringer approved these changes Aug 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 96475 1

2 packages built:
- python37Packages.jupyterhub-tmpauthenticator
- python38Packages.jupyterhub-tmpauthenticator

@jonringer jonringer merged commit c4330a0 into NixOS:master Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chiroptical @jonringer