Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libreoffice-fresh: 6.4.3.2 -> 7.0.0.3 #96474

Merged
merged 1 commit into from Sep 3, 2020
Merged

libreoffice-fresh: 6.4.3.2 -> 7.0.0.3 #96474

merged 1 commit into from Sep 3, 2020

Conversation

dguibert
Copy link
Member

Motivation for this change

Better MS support.
https://wiki.documentfoundation.org/ReleaseNotes/7.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

7c6f434c
7c6f434c approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@7c6f434c 7c6f434c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me

@ofborg ofborg bot requested a review from 7c6f434c August 27, 2020 16:11
@Mindavi
Copy link
Contributor

Mindavi commented Aug 27, 2020

Currently building. I've seen some warnings pass by like these:

cc1: warning: command line option '-fno-visibility-inlines-hidden' is valid for C++/ObjC++ but not for C

Doesn't really matter because it's just a warning, but I was wondering if there's an override in nixpkgs for CXXFLAGS instead of all CFLAGS?

I'll go to sleep now and give an update on how it works when I wake up :) (and have some time).

Mindavi
Mindavi reviewed Aug 27, 2020
View reviewed changes
pkgs/applications/office/libreoffice/src-fresh/download.nix
url = "http://dev-www.libreoffice.org/src/../extern/odfvalidator-1.2.0-incubating-SNAPSHOT-jar-with-dependencies-971c54fd38a968f5860014b44301872706f9e540.jar";
sha256 = "984f2a479df79e27e7b01a5815ac53ae64e07746b882262d8a64566494515504";
name = "odfvalidator-0.9.0-RC2-SNAPSHOT-jar-with-dependencies-2726ab578664434a545f8379a01a9faffac0ae73.jar";
url = "http://dev-www.libreoffice.org/src/../extern/odfvalidator-0.9.0-RC2-SNAPSHOT-jar-with-dependencies-2726ab578664434a545f8379a01a9faffac0ae73.jar";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason for keeping the /src/../extern/ like that? It can be replaced with just /extern/, no?

@7c6f434c
Copy link
Member

7c6f434c commented Aug 27, 2020 via email

@Mindavi
Copy link
Contributor

Mindavi commented Aug 28, 2020 •
edited

Oh, I didn't know it was generated. Then of course it doesn't really matter. Just keep it as-is.

Everything built and seems to work fine. I see some warnings (during saving in writer) but they're probably not nix-specific, so I think it's all good. I've tried to run all binaries and they all seem to work as expected.

(soffice:6196): dconf-WARNING **: 07:59:06.668: failed to commit changes to dconf: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name ca.desrt.dconf was not provided by any .service files

hax404
hax404 approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@hax404 hax404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds and works for me.

@7c6f434c 7c6f434c merged commit d46e488 into NixOS:master Sep 3, 2020
@B4dM4n B4dM4n mentioned this pull request Sep 3, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hax404 hax404 hax404 approved these changes

@Mindavi Mindavi Mindavi approved these changes

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dguibert @Mindavi @7c6f434c @veprbl @hax404