Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: eb75282b8dc8
Choose a base ref
...
head repository: NixOS/nix
compare: f4d3b4fb76e6
Choose a head ref
  • 2 commits
  • 1 file changed
  • 2 contributors

Commits on Aug 27, 2020

  1. Pass all args when auto-calling a function with an ellipsis 

    The command line options --arg and --argstr that are used by a bunch of
CLI commands to pass arguments to top-level functions in files go
through the same code-path as auto-calling top-level functions with
their default arguments - this, however, was only passing the arguments
that were *explicitly* mentioned in the formals of the function - in the
case of an as-pattern with an ellipsis (eg args @ { ... }) extra passed
arguments would get omitted. This fixes that to instead pass *all*
specified auto args in the case that our function has an ellipsis.

Fixes #598
    @glittershark
    glittershark committed Aug 27, 2020
    Copy the full SHA
    6262007 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #3965 from glittershark/fix-top-level-ellipsis 

    Pass all args when auto-calling a function with an ellipsis
    @edolstra
    edolstra committed Aug 27, 2020
    Copy the full SHA
    f4d3b4f View commit details
    Browse the repository at this point in the history